Repository navigation
ci(canonical): replay the ai-agent-action conformance suite and require jcs-admit 0.1.1 - #228
Open
astrogilda wants to merge 4 commits into
Open
astrogilda wants to merge 4 commits into
astrogilda wants to merge 4 commits into
Conversation
jcs-admit 0.1.1 lowers its serde floor, so the lockfile no longer has to carry serde 1.0.229 and the syn 3.0.6 it brought in. Against the lockfile before the admission layer was added, jcs-admit is now the only package that differs. Signed-off-by: Sankalp Gilda <sankalp.gilda@gmail.com>
Add an ignored test that reads a checkout of the suite and holds every statement and record line to the verdict its manifest implies: a byte fault must be refused by admit_document, every other document must be admitted, and each record line of an accept vector must already be canonical. A new CI job checks out agent-evidence-vectors at v0.13.0 and runs it. With the admission result ignored, four vectors fail. Signed-off-by: Sankalp Gilda <sankalp.gilda@gmail.com>
Contributor
|
Hey, I'm reviewing open PRs and see there is a conflict. I have it fixed locally but some reason github is rejecting my changes. Is there any way you could resolve the conflicts? |
Contributor
|
Ah, found the reason. |
Signed-off-by: Sankalp Gilda <23521054+astrogilda@users.noreply.github.com> # Conflicts: # Cargo.lock
Pin the checkout to the commit behind the v0.25.0 tag rather than the v0.13.0 tag name. The suite now has 75 vectors; the test reads 120 documents from 74 of them and passes. With admit_document replaced by a plain serde_json parse, five vectors fail. Signed-off-by: Sankalp Gilda <23521054+astrogilda@users.noreply.github.com>
Contributor
Author
|
@graywolf336 done: I merged dev into the branch, so it's conflict-free at 8288324. I also moved the suite to the v0.25.0 commit, and the new CI job passes on it. |
Contributor
|
@astrogilda would you be willing to update our docs to add a section to the software supply chain and how it maps back to atomic? We are looking to merge your changes this week and we wanting to make sure our documentation is updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @graywolf336 for merging #204.
This adds a CI job that runs the ai-agent-action suite from probityai/agent-evidence-vectors against atomic-canonical. The new conformance_corpus test reads 120 documents from 74 of the 75 vectors at the v0.25.0 commit and holds each to its manifest verdict. A byte fault such as a repeated member or an unsafe integer must be refused by
jcs::admit_document, and every other document must be admitted. Record lines in accept vectors must also matchjcs::canonicalizebyte for byte. With the admission call replaced by a plain serde_json parse, five vectors fail.The test skips v43175cd2ad003639, whose extensions member nests 128 deep and puts its statement at depth 130, past the 128-level MAX_DEPTH in atomic-canonical.
The manifest now requires jcs-admit 0.1.1, which the dev lockfile already resolves, so Cargo.lock matches dev.
Edited 2026-10-23: merged dev, moved the suite from v0.13.0 to the v0.25.0 commit, and updated the counts and the lockfile note.